Approved.  Nice way to alleviate the problem a little bit.

On 2010-04-02, at 15:37, Henry Minsky wrote:

> Change 20100402-hqm-7 by [email protected] on 2010-04-02 15:27:52 EDT
>    in /Users/hqm/openlaszlo/trunk3
>    for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: add compiler errors for empty attribute values
> 
> New Features:
> 
> Bugs Fixed: LPP-7106 Compiler error message issue
> 
> Technical Reviewer: ptw
> QA Reviewer: a.bargull
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Release Notes:
> 
> Overview:
> 
> Created a list of LZX attribute types which are not allowed to have
> literal empty strings (or whitespace) as values in LZX source code.
> 
> These are 
> ViewSchema.BOOLEAN_TYPE,
> ViewSchema.EVENT_HANDLER_TYPE,
> ViewSchema.EXPRESSION_TYPE,
> ViewSchema.NODE_TYPE,
> ViewSchema.NUMBER_EXPRESSION_TYPE,
> ViewSchema.NUMBER_TYPE,
> ViewSchema.REFERENCE_TYPE,
> ViewSchema.SIZE_EXPRESSION_TYPE
> 
> 
> Details:
> 
> ViewSchema: Created a list, sNonEmptyValueTypes, of attribute types
> that cannot have empty (or whitespace) string values
> n
> NodeModel: Modified the constructor for CompiledAttribute to throw an error if
> an empty value is specified for one of the sNonEmptyValueTypes.
> 
> Tests:
> 
> smokecheck compiles without error
> lzpix  compiles without error
> calendar  compiles without error
> 
> test/compiler_errors/empty-attribute.lzx
>  generates errors for the empty attributes
> 
> Files:
> A       test/compiler_errors/empty-attribute.lzx
> M       WEB-INF/lps/server/src/org/openlaszlo/compiler/ViewSchema.java
> M       WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100402-hqm-7.tar
> 


Reply via email to