Nit: 1) It would probably be better if the code that chooses the attrs map and adds the binder and dependency method were a subroutine called from the two places it exists, rather than the cut/paste implementation that is there today. Bonus points if you can do that. :)
Otherwise, Approved. On 2010-04-07, at 13:28, Henry Minsky wrote: > Change 20100407-hqm-z by [email protected] on 2010-04-07 08:41:18 EDT > in /Users/hqm/openlaszlo/trunk3 > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: fix problem with NodeModel addAttributeElement() method > > New Features: > > Bugs Fixed: LPP-8883 bug in NodeModel addAttributeElement > > Technical Reviewer: ptw > QA Reviewer: (pending) > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Overview: > > > Details: > > + don't bash 'attrs' instance var > + throw error if you try to set a constraint on a static (allocation="class") > var > > > Tests: > > test/smoke/smokecheck.lzx > > test case: > > style.css: > bug_8883_tester { > background-color: "blue"; > } > > <canvas> > <stylesheet src="style.css"/> > <class name="bug_8883_tester"> > <attribute name="foo" type="string" style="background-color" > value="red"/> > <attribute name="bar" allocation="class" style="background-color" > type="string" value="red"/> > </class> > <bug_8883_tester id="bug8883inst"/> > </canvas> > > > > > Files: > M WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java > > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100407-hqm-z.tar >
