Not yet approved:
- changing runtime doesn't work when using
"http://localhost/trunk/laszlo-explorer/";
- dhtml-lfc is always loaded, also for swf-runtimes
- shadows aren't displayed in dhtml, but running
explorer-nav.lzx?lzr=dhtml works for me
quick-index.xslt - Formally check in (why was this missing) and update to refer
to laszlo-explorer/index.html instead of index.jsp.
Don't check in that file, instead modify the original under
docs/src/quick-index.xslt
explore-nav* - Add SOLO compiled versions of the app.
I'd prefer if this was handled automatically. There is already an ant
target for the lazlo-explorer in /build.xml, what about enhancing that
target to generate the SOLO apps?
+ lz.Browser.callJS('eval', null, 'top.document.title="' + title + '"');
+ //lz.Browser.setWindowTitle(title);
setWindowTitle is checked in, so you can now use the proper call (I know
it wasn't committed when you made this change :-) )
+ if (this.onreplicationdone.ready) this.onreplicationdone.sendEvent(clone);
This event seems to be unused?
+ var url =
label.formatToString("content.jsp?src=%s&tag=%s&title=%s&action=%s&lzr=%s",
src, tagline, title, action, runtime);
+ browser.loadURL(url, (action == 'source') ? 'source' : 'content');
Sources are now displayed in the iframe and no longer in a separate
window, is this change intended? (I'm fine with this change, just want
to make sure it's what you want.)
+ this.url = url;
+ url = url.toString();
I don't understand why you need to call toString() here.
+ <attribute name="bookmark" value="" type="text"/>
bookmark is an Array, why is its type set to text?
+ var url = lz.Browser.callJS('eval', null, 'window.location');
Why don't you use "lz.Browser.getLoadURLAsLzURL()"? That's the preferred
method to obtain the application url.
On 4/5/2010 9:51 PM, Max Carlson wrote:
Change 20100401-maxcarlson-j by maxcarl...@bank on 2010-04-01 15:12:44 PDT
in /Users/maxcarlson/openlaszlo/trunk-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: UPDATED AGAIN: Modernize laszlo-explorer
Bugs Fixed: LPP-8875 - laszlo-explorer should be a self-contained application
capable of changing runtimes dynamically, LPP-3640 - Laszlo Explorer should be
SOLO
Technical Reviewer: [email protected]
QA Reviewer: ptw
Details:
index.jsp - Replace with static page, index.html
explore-nav - Add history support so refreshing the page restores back to the same
location, bookmarking works and the browser forward/back buttons allow navigation
back through the history. Update the title of the page when changing topics. Add
radio button to select runtime. Use<html/> instead of a frameset to load HTML
content. Incorporate Andre's changes to improve readability and clarity of the app.
explore-nav* - Add SOLO compiled versions of the app.
quick-index.xslt - Formally check in (why was this missing) and update to refer
to laszlo-explorer/index.html instead of index.jsp.
Tests: laszlo-explorer/index.html works across all runtimes and when the
runtime is changed restores to the current location.
Files:
A laszlo-explorer/explore-nav.lzx.swf8.swf
D laszlo-explorer/index.jsp
A laszlo-explorer/explore-nav.lzx.js
A laszlo-explorer/explore-nav.sprite.png
A laszlo-explorer/explore-nav.lzx.swf10.swf
A laszlo-explorer/index.html
M laszlo-explorer/explore-nav.lzx
A quick-index.xslt
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20100401-maxcarlson-j.tar
