Suggestion: 1) I think we should all use a code style that keeps an attribute adjacent to its corresponding event and setter when they exist. This makes it easier to understand the code and will reduce the chance that you make the think-oh that I am rejecting this change for. So, for example, you should say:
<attribute name="foo" ... <!--- @access private --> <event name="onfoo" ... <!--- @access private --> <setter name="foo" ... Issues: 1) You have named your setters "on...", which I don't think you meant. Approved if you fix the issue. On 2010-04-06, at 19:42, Max Carlson wrote: > Change 20100406-maxcarlson-x by maxcarl...@bank on 2010-04-06 16:36:54 PDT > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Add AS3 microphone properties, ability to set RTMP AMF encoding > > Bugs Fixed: LPP-8882 - Add ability to set AS3 microphone properties and AMF > object encoding > > Technical Reviewer: ptw > QA Reviewer: hminsky > > Release Notes: All APIs available to microphones are now accessible, and RTMP > connections can set their AMF encoding type. > > Details: microphone - Add codec, encodequality, framesperpacket, rate final > attributes and rate, gain and echosuppression attributes with appropriate > setters and events. > > rtmpconnection - Add objectencoding attribute, used to set the AMF object > encoding version. > > Tests: test/video/test-microphone.lzx and test/video/test-rtmpconnection.lzx > run as before in swf8/9/10 > > Files: > M lps/components/extensions/av/microphone.lzx > M lps/components/extensions/av/rtmpconnection.lzx > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100406-maxcarlson-x.tar >
