Change 20100401-maxcarlson-j by maxcarl...@bank on 2010-04-01 15:12:44 PDT
in /Users/maxcarlson/openlaszlo/trunk-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: UPDATE ^3: Modernize laszlo-explorer
Bugs Fixed: LPP-8875 - laszlo-explorer should be a self-contained application
capable of changing runtimes dynamically, LPP-3640 - Laszlo Explorer should be
SOLO
Technical Reviewer: [email protected]
QA Reviewer: ptw
Details: I'm going to go ahead and check this in since it works well for me.
Updated to address Andre's comments:
- changing runtime doesn't work when using
"http://localhost/trunk/laszlo-explorer/";
- dhtml-lfc is always loaded, also for swf-runtimes
- shadows aren't displayed in dhtml, but running explorer-nav.lzx?lzr=dhtml
works for me
These are all fixed.
> quick-index.xslt - Formally check in (why was this missing) and update to
> refer to laszlo-explorer/index.html instead of index.jsp.
Don't check in that file, instead modify the original under
docs/src/quick-index.xslt
Fixed.
> explore-nav* - Add SOLO compiled versions of the app.
I'd prefer if this was handled automatically. There is already an ant target
for the lazlo-explorer in /build.xml, what about enhancing that target to
generate the SOLO apps?
I added a build.xml in the laszlo-explorer directory to rebuild the app.
> + lz.Browser.callJS('eval', null, 'top.document.title="' + title + '"');
> + //lz.Browser.setWindowTitle(title);
setWindowTitle is checked in, so you can now use the proper call (I know it
wasn't committed when you made this change :-) )
Fixed :)
> + if (this.onreplicationdone.ready) this.onreplicationdone.sendEvent(clone);
This event seems to be unused?
Yeah, good catch!
> + var url =
> label.formatToString("content.jsp?src=%s&tag=%s&title=%s&action=%s&lzr=%s",
> src, tagline, title, action, runtime);
> + browser.loadURL(url, (action == 'source') ? 'source' : 'content');
Sources are now displayed in the iframe and no longer in a separate window, is
this change intended? (I'm fine with this change, just want to make sure it's
what you want.)
Thanks, I fixed this.
> + this.url = url;
> + url = url.toString();
I don't understand why you need to call toString() here.
I was getting back a complete copy of the window.location object so it needed
to be serialized to a string. This has been simplified.
> + <attribute name="bookmark" value="" type="text"/>
bookmark is an Array, why is its type set to text?
There is no <attribute type="array"/> see
http://jira.openlaszlo.org/jira/browse/LPP-8887
> + var url = lz.Browser.callJS('eval', null, 'window.location');
Why don't you use "lz.Browser.getLoadURLAsLzURL()"? That's the preferred method
to obtain the application url.
I added a new API to read the current browser location bar, which is different
than the application load URL.
LzBrowser - Add getURL() API, update comment for getLoadURL().
quick-index.xslt - Update to refer to laszlo-explorer/index.html instead of
index.jsp.
build.xml - Add ant script to rebuild the explorer
index.jsp - Replace with static page, index.html
explore-nav - Add history support so refreshing the page restores back to the
same location, bookmarking works and the browser forward/back buttons allow
navigation back through the history. Update the title of the page when
changing topics. Add radio button to select runtime. Use <html/> instead of a
frameset to load HTML content. Incorporate Andre's changes to improve
readability and clarity of the app.
explore-nav.sprite.png - Add to work around LPP-8907 - DHTML: command-line
compiler build incomplete master sprite.
explore-nav* - Add SOLO compiled versions of the app.
Tests: laszlo-explorer/index.html works across all runtimes and when the
runtime is changed restores to the current location.
Files:
M WEB-INF/lps/lfc/services/LzBrowser.lzs
M docs/src/quick-index.xslt
A laszlo-explorer/build.xml
D laszlo-explorer/index.jsp
A laszlo-explorer/explore-nav.sprite.png
A laszlo-explorer/index.html
M laszlo-explorer/explore-nav.lzx
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20100401-maxcarlson-j.tar
