That appears even simpler and better! Thanks. Approved.
[I added a couple more tests to the smoke/compiler suite for subclassof. Just to make sure... :)] On 2010-04-27, at 19:48, André Bargull wrote: > I've attached an alternative solution which uses getQualifiedClassName() > instead of getDefinitionByName() in $lzsc$issubclassof(). This solution works > without changing the compiler and should also provide better runtime > performance. > > > > On 4/28/2010 4:00 AM, André Bargull wrote: >> Change 20100428-bargull-zlC by barg...@bargull02 on 2010-04-28 03:48:54 >> in /home/anba/src/svn/openlaszlo/trunk >> for http://svn.openlaszlo.org/openlaszlo/trunk >> >> Summary: make all class definitions public >> >> New Features: >> >> Bugs Fixed: LPP-8942 ($lzc$issubclassof does not work for mixins in as3 >> non-debug) >> >> Technical Reviewer: ptw >> QA Reviewer: (pending) >> Doc Reviewer: (pending) >> >> Documentation: >> >> Release Notes: >> >> Overview: >> >> >> Details: >> flash.utils.getDefinitionByName() does only work for public definitions, >> otherwise a ReferenceError is thrown. Therefore all classes are now defined >> as public. This makes subclassof work in non-debug, because >> $lzc$issubclassof uses getDefinitionByName(). >> >> >> Tests: >> smokecheck, metasuite in swf10 (non-debug, debug) >> >> Files: >> M WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9ParseTreePrinter.java >> >> Changeset: >> http://svn.openlaszlo.org/openlaszlo/patches/20100428-bargull-zlC.tar >> > <patch.diff>
