Questions: 1) Is there a way to get the source image's height and width and just default each of h and w to that (separately) if they are null? As written (line 614 ff.), if I specify default (null) w, h will be ignored. (The swf branch gets this right.)
2) Do we allow styling the lineheight of a font (the baseline spacing)? If so, shouldn't that be included in __styleText(); In CSS you can specify a font size as x/y, e.g., 11pt/13pt, meaning 11pt text on 13pt leading, which is a common "open" layout for type to make it feel "lighter". Otherwise, approved. On 2010-05-06, at 15:24, Max Carlson wrote: > Change 20100506-maxcarlson-S by [email protected] on 2010-05-06 > 10:24:45 PDT > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Add fillText(), strokeText() and update drawImage() for DHTML > drawview > > Bugs Fixed: LPP-8974 - Add text API support to drawview > > Technical Reviewer: ptw > QA Reviewer: hminsky > > Release Notes: Drawview now supports strokeText() and fillText() in DHTML. > In addition, passing null for the image argument to drawImage() will cause > the current canvas to be copied when drawing the bitmap. > > Details: Update drawImage() to use the current canvas state when image args > is null and deal with unspecified args better. Add fillText() and > strokeText() implementations and a shared method to copy the drawview font > settings to the canvas. Update stub warning methods to use $runtime. Add > stub warning methods for Flash fillText() and strokeText(). Fix swf > drawImage() to respect new arg signature and current applied transformations. > > Tests: See testcase at LPP-8974. Text rendering is not supported yet in aS3 > and the testcase will warn, but copying/mirrorint the canvas with > transformations is with this change - see the mirror image of the triangle. > > Files: > M lps/components/extensions/drawview.lzx > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100506-maxcarlson-S.tar >
