Question: 1) I guess the idea of precache is to trigger any loading error. But maybe you should just add the error handler in debug and never precache, so debug is less different from real?
Otherwise, approved. On 2010-05-07, at 13:41, Max Carlson wrote: > Change 20100507-maxcarlson-f by [email protected] on 2010-05-07 > 10:08:18 PDT > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: DHTML master sprites use approot parameter when provided. > > Bugs Fixed: LPP-8981 - DHTML: master sprite URL not respecting approot > parameter > > Technical Reviewer: ptw > QA Reviewer: hminsky > > Details: Update masterspriteurl to include the approot. Only preload the > image in debug mode, where we can see any error that might happen. Add > explicit position for lzTextSizeCache to prevent it from triggering page > reflows/renders. Shorten lookups in writeCSS(), add correct defaults to > sprite.visible/opacity, and remove unused sprite.text property. > > Tests: See testcase at LPP-8981 > > Files: > M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100507-maxcarlson-f.tar
