On Thu, May 13, 2010 at 4:24 PM, P T Withington <[email protected]>wrote:
> Comments:
>
> 1) In DHTMLWriter can you add a comment explaining why you ignore the
> compilingSnippet argument?
>
>
OK. I made that API and flag because SWF10 needs to set up the boilerplate
as3 templates differently for snippets, but the DHTML compiler doesn't need
to do anything different at this point.
The AS3-specific stuff , all of these
props.setProperty(org.openlaszlo.sc.Compiler.SWF9_APPLICATION_PREAMBLE,
makeLibraryPreamble());
props.put(org.openlaszlo.sc.Compiler.SWF9_APP_CLASSNAME,
LIBRARY_CLASSNAME);
props.put(org.openlaszlo.sc.Compiler.SWF9_WRAPPER_CLASSNAME,
LIBRARY_CLASSNAME);
should eventually moved into the script compiler, out of the tag compiler.
Another question, does anyone
really rely on snippets at this point? Is it worth the effort of supporting
them in all our runtimes?
> Issues:
>
> 1) Seems to me that ScriptBuffer should be pushed down into
> IntermediateWriter, which should override addScript to accumulate the
> script, rather than the if-test in DHTMLWriter/addScript -- if you are not
> linking, you will already have an IntermediateWriter as your ObjectWriter,
> so you should not need to consult the flag any more, right?
>
I'll see if I can do that.
>
> Otherwise, Approved.
>
> On 2010-05-13, at 15:25, Henry Minsky wrote:
>
> > fixed broken mixin bug in swf10
> >
> > Change 20100512-hqm-k by [email protected] on 2010-05-12 13:00:29 EDT
> > in /Users/hqm/openlaszlo/trunk2
> > for http://svn.openlaszlo.org/openlaszlo/trunk
> >
> > Summary: make DHTML compiler use less peak RAM
> >
> > New Features:
> >
> > Bugs Fixed: LPP-8994
> >
> > Technical Reviewer: ptw
> > QA Reviewer: max
> > Doc Reviewer: (pending)<Randal Scott Hunter wants to be friends on
> Facebook..eml>
> >
> > Documentation:
> >
> > Release Notes:
> >
> > Overview:
> >
> >
> > Details:
> >
> > + Create new subclass of sc.Compiler, sc.DHTMLCompiler, which supports
> the startApp(), compileBlock(), finishApp() API
> >
> > + DHTMLWriter: call compileBlock() method from addScript
> >
> > + JavascriptGenerator:
> > Added compileBlock method
> > Added persistent output stream to tmp file
> > Added code to accumulate script output, and persistent parser object
> >
> > + Main.java: added back AST tree debugging options
> >
> > Tests:
> >
> > + ant lztest
> >
> > + smokecheck in swf10, dhtml
> >
> > + lzpix in dhtml compiles and runs
> >
> > + lzo's still work (tested lzpix with some of the files in classes/
> directory compiled to lzos)
> >
> > + dhtml snippets still work: test/snippets/import-class.lzx?lzr=dhtml
> >
> > + swf10 mixins work "lzc --runtime=swf10 test/drawing/drawing.lzx"
> >
> > Files:
> > M WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java
> > M WEB-INF/lps/server/src/org/openlaszlo/sc/SWF10Compiler.java
> > M WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java
> > A WEB-INF/lps/server/src/org/openlaszlo/sc/DHTMLCompiler.java
> > M WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
> > M WEB-INF/lps/server/src/org/openlaszlo/compiler/DHTMLWriter.java
> > M
> WEB-INF/lps/server/src/org/openlaszlo/compiler/ImportCompiler.java
> > M WEB-INF/lps/server/src/org/openlaszlo/compiler/Compiler.java
> > M WEB-INF/lps/server/src/org/openlaszlo/compiler/Main.java
> > M WEB-INF/lps/server/src/org/openlaszlo/compiler/SWF9Writer.java
> >
> >
> > Changeset:
> http://svn.openlaszlo.org/openlaszlo/patches/20100512-hqm-k.tar
>
>
--
Henry Minsky
Software Architect
[email protected]
