We decided I imagined this, that I was thinking about the tag compiler. On 2010-05-20, at 09:25, Henry Minsky wrote:
> Do you remember where that test case is? > > > On Thu, May 20, 2010 at 8:43 AM, P T Withington <[email protected]>wrote: > >> How is the resource situation different than a forward class reference? >> >> Since classes (and mixins) have to be emitted before they are referenced, >> don't we have the same problem? You had a test case for defining a class >> after it is used (in script) that needs to still work. >> >> On 2010-05-20, at 08:31, Henry Minsky wrote: >> >>> It's still deterministic, but there is one thing out of order that we >> need >>> to do, which is to accumulate every resource declaration as we hit them >> but >>> then prepend them all at the start of the js object file. That used to >> be >>> easy to do , just prepend it before sending the whole app to the script >>> compiler. Now that we don't have the whole program lzs buffered, we can >>> manage to still prepend this stuff because the script compiler output is >>> buffered in a tmp file, so we can output the resource declarations to the >>> final output file, and then copy the tmp file after that. >>> >>> >>> >>> On Thu, May 20, 2010 at 6:38 AM, P T Withington <[email protected] >>> wrote: >>> >>>> Is there a deeper problem here? Are you saying addScript is >>>> non-deterministic? Certainly there are other places in the compiler >> that >>>> expect things to be written in order (like classes defined before used). >>>> >>>> On 2010-05-19, at 19:52, Max Carlson wrote: >>>> >>>>> Change 20100519-maxcarlson-d by maxcarl...@friendly on 2010-05-19 >>>> 16:45:20 PDT >>>>> in /Users/maxcarlson/openlaszlo/trunk-clean >>>>> for http://svn.openlaszlo.org/openlaszlo/trunk >>>>> >>>>> Summary: Fix DHTML master sprites >>>>> >>>>> Bugs Fixed: LPP-9016 - regression: DHTML master sprites not working >>>>> >>>>> Technical Reviewer: hminsky >>>>> QA Reviewer: ptw >>>>> >>>>> Details: DHTMLCompiler - Correct comment >>>>> >>>>> DHTMLWriter - Remove extra spaces in mResourceDefs resource table, now >>>> that it's not being minified by script compiler. addResourceDefs() >> writes >>>> the resource table directly to the outputstream, to ensure it's written >>>> first. >>>>> >>>>> Tests: cd laszlo-explorer; lzc --runtime=dhtml explore-nav.lzx. >>>> explore-nav.js LzResourceLibrary entries will be on the first line. >>>>> >>>>> Files: >>>>> M WEB-INF/lps/server/src/org/openlaszlo/sc/DHTMLCompiler.java >>>>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/DHTMLWriter.java >>>>> >>>>> Changeset: >>>> http://svn.openlaszlo.org/openlaszlo/patches/20100519-maxcarlson-d.tar >>>>> >>>> >>>> >>> >>> >>> -- >>> Henry Minsky >>> Software Architect >>> [email protected] >> >> > > > -- > Henry Minsky > Software Architect > [email protected]
