Agree with both of André's comments. Let's not Perl ourselves with multiple
ways to do everything. And, if the point of getInitArgs is to get the
parameters that are coming in on the URL then we need to do that, not just
return the global/_root object.
And surely the priority of LPP-9023 should be very high. Letting someone smash
arbitrary globals into your app by appending them to the URL seems like a
recipe for disaster!
On 2010-05-21, at 10:00, André Bargull wrote:
> Why did you add "getInitArgs()" and "getInitArg(null)" to retrieve all query
> parameters? That seems to be a bit redundant.
>
> Implementing LPP-7934 ("DHTML: don't store initial args in global object")
> should help to restrict getInitArgs() to the real initialization arguments
> for DHTML.
>
>
>
> On 5/21/2010 2:29 AM, Max Carlson wrote:
>> Change 20100520-maxcarlson-M by maxcarl...@friendly on 2010-05-20 17:27:32
>> PDT
>> in /Users/maxcarlson/openlaszlo/trunk-clean
>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: Add lz.Browser.getInitArgs() to retreive object containing all args
>>
>> Bugs Fixed: lpp-9023 - Want a way to get all query parameters at once
>>
>> Technical Reviewer: hminsky
>> QA Reviewer: dwheeler
>>
>> Details: LzBrowserKernel - Add getInitArgs() implementation.
>>
>> LzBrowser - Add getInitArgs().
>>
>> Tests: See testcase at lpp-9023
>>
>> Files:
>> M WEB-INF/lps/lfc/kernel/swf/LzBrowserKernel.lzs
>> M WEB-INF/lps/lfc/kernel/dhtml/LzBrowserKernel.lzs
>> M WEB-INF/lps/lfc/kernel/swf9/LzBrowserKernel.lzs
>> M WEB-INF/lps/lfc/services/LzBrowser.lzs
>>
>> Changeset:
>> http://svn.openlaszlo.org/openlaszlo/patches/20100520-maxcarlson-M.tar
>>
>>
>>
