In addition to Tucker's notes:
+ this.__animExpected = {};
+ this.__animCounter = {};
Only a few nodes will be animated in an application, so both hashes
should be built lazily. Otherwise every node construction will cost +2
Objects.
[...]
+ var __animExpected = {};
[...]
+ var __animCounter = {};
Every node construction will cost +4 Objects for swf9/10
(http://jira.openlaszlo.org/jira/browse/LPP-5232).
@@ -218,23 +227,32 @@
var attr:String = this.attribute;
var from:* = this.from;
+ var expected = targ.__animExpected;
+ var expectedvalue = (expected[attr] != null ? expected[attr]
: targ[attr]); // inlined targ.getExpectedAttribute(attr);
if (from != null) {
targ.setAttribute(attr, from);
- var d:Number = from - targ.getExpectedAttribute(attr);
- targ.addToExpectedAttribute(attr, d);
+ var d:Number = from - expectedvalue;
+ // inlined targ.addToExpectedAttribute(attr, d);
+ var current = expected[attr];
+ expected[attr] = (current != null ? current : targ[attr])
+ d;
}
if (! this.relative) {
- this.to = this.origto - targ.getExpectedAttribute(attr);
+ this.to = this.origto - expectedvalue;
This seems to be wrong:
expected[attr] is updated (inlined call to addToExpectedAttribute), but
later "expectedvalue" is used again.
On 5/25/2010 4:54 PM, P T Withington wrote:
Comments:
1) I'd just remove all the animator functions you commented out of LzNode.
They are clutter and will (already for one of them) rot. svn can find them if
we really need them back.
You mean to rot like setExpectedAttribute() which wasn't updated to use
__animExpected ;-)
2) Rather than creating multiple object hashes for the various animation
attributes, why not define a class (data structure) that holds all the
animation properties of an attribute? Thus, when animating an attribute, you
will just say something like:
var aas = this.__animatedAttributes;
if (! aas[name]) { aas[name] = new AnimationAttribute(start, end, ...);
?
On 2010-05-24, at 20:20, Max Carlson wrote:
Change 20100524-maxcarlson-q by maxcarl...@friendly on 2010-05-24 17:18:32 PDT
in /Users/maxcarlson/openlaszlo/trunk-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Clean up animator/node interaction
Bugs Fixed: LPP-9020 - Support CSS3 transitions (partial)
Technical Reviewer: ptw
QA Reviewer: hminsky
Details: LzNode - Comment out simplified versions of animator methods now that
they're inlined in LaszloAnimation.
LaszloAnimation - Shorten lookpus, inline calls to LzNode for clarity,
performance.
Tests: Animators work as before across runtimes
Files:
M WEB-INF/lps/lfc/core/LzNode.lzs
M WEB-INF/lps/lfc/controllers/LaszloAnimation.lzs
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20100524-maxcarlson-q.tar
