Approved!

People always want to stash data in the lz.Delegate - it should really be more like a closure - see LPP-8961 - Replace delegates with method closures.

We should definitely put a release note in about this - can you make sure the release notes field for the bug talks about the fix? I'd like to leave this in - but you're right that it is somewhat risky.. Then again, there's an easy fix.

Regards,
Max Carlson
OpenLaszlo.org

On 5/29/10 9:58 AM, André Bargull wrote:
This makes me wonder whether it's possible to ship 4.8 with a sealed
lz.Delegate class...

Change 20100529-bargull-BK2 by barg...@bargull02 on 2010-05-29 18:48:34
in /home/anba/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Making delegate a sealed class broke combobox selection

Bugs Fixed: LPP-9038 (OL 5.0.x - SWF10 - Components Sample - The
Pistachio combobox can not work well)

Technical Reviewer: max
QA Reviewer: (pending)

Details:
lz.Delegate is no longer a dynamic class, that means it's no longer
possible to attach custom properties to instances of lz.Delegate. Just
changed basecombobox to store the selection start and end point directly
in the instance.


Tests:
see bugreport

Files:
M lps/components/base/basecombobox.lzx

Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20100529-bargull-BK2.tar


Reply via email to