Re: [Laszlo-reviews] For Review: Change 20100608-ptw-v Summary: Catch and report errors in callbacks in the as3 idle kernel

Wed, 09 Jun 2010 02:12:24 -0700 

Not approved, because it doesn't address the real bug.
Hint: Take a look at the LzIdleKernel.__update() implementation for swf8/dhtml and compare it to the implementation for swf9/10. 

I'll attach a minimal test case to the bug report.


On 6/9/2010 3:10 AM, P T Withington wrote:

Change 20100608-ptw-v by [email protected] on 2010-06-08 21:07:14 EDT
     in /Users/ptw/OpenLaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Catch and report errors in callbacks in the as3 idle kernel

Bugs Fixed:  LPP-9097 swf10 idle kernel does not catch errors in callbacks

Technical Reviewer: [email protected] (pending)
QA Reviewer: mdemmon (pending)

Details:
     Put a try/catch around the callback, report the error if debug is on

Tests:
     Maynard will test against wt

Files:
M       WEB-INF/lps/lfc/kernel/swf9/LzIdleKernel.as


Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100608-ptw-v.tar

Reply via email to