Approved. I totally missed that, despite having (apparently) fixed it in the swf8/dhtml version.
On 2010-06-09, at 06:13, André Bargull wrote: > The performance improvements need to be performed for the shared swf8/dhtml > idle kernel, too. I'll do that later. > > > Change 20100609-bargull-bcN by barg...@bargull02 on 2010-06-09 12:02:19 > in /home/anba/src/svn/openlaszlo/trunk > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: finish "Make Idle Kernel safer" for swf9/10 > > Bugs Fixed: LPP-9097 (swf10 idle kernel does not catch errors in callbacks) > > Technical Reviewer: ptw > QA Reviewer: mdemmon > > Details: > It's not safer when the callbacks array is always referenced directly instead > of a local variable. > > Also added some performance improvements: > - addCallback(): only make a copy when necessary; length check not needed in > if-clause because after a push operation length is always > 0 > - removeCallback(): only make a copy when necessary; return after first hit; > __listening check not needed in if-clause because __listening=true for > callbacks.length>0 > > > Tests: > test case attached at bug report > > Files: > M WEB-INF/lps/lfc/kernel/swf9/LzIdleKernel.as > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100609-bargull-bcN.tar >
