Nice simplification! Comments:
1) LaszloView#460: Remove this comment, it makes no sense now that there is no clickregion 2) LaszloView#468: Please date and sign the comment, so we know where to go for more information Approved. On 2010-06-17, at 23:57, Max Carlson wrote: > Change 20100604-maxcarlson-Q by maxcarl...@friendly on 2010-06-04 23:25:17 PDT > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Make view.clickregion runtime-only > > New Features: view.clickregion allows the view's click region to be set/unset > at runtime. > > Bugs Fixed: LPP-9089 - Add ability to use resource as a click mask > > Technical Reviewer: ptw > QA Reviewer: hminsky > > Release Notes: view.clickmask allows the view's click region to be set. > > Details: Updated to address Tucker's comments: > > 1) We don't document implicit events, events associated with attributes, > because they just clutter the documentation. So you should make onclickmask > private. > > Fixed > > 2) What about onclickregion? > > Fixed. > > 3) Is there no way to unify these interfaces? I can't really see what the > difference is. Don't they both take resources that describe the hotspot? > > I changed the app to use clickregion/onclickregion instead of introducing a > new API. > > 4) Your change is stale, needs to be updated to ToT. > > Fixed. > > 5) Mask does not work in swf8. The whole rectangle is always clickable. > > I had to make the clickable/mask setup explicit in LzView.construct() > > 6) DHTML gives "lpp-9089.lzx:2:46: file not found: mask.swf" > > I updated the testcase. > > */LzSprite.as - Update setClickRegion() implementation, set clickregion > capability to true, remove unused capabilities. > > LzSprite.js - Rename capabilities.clickmasking -> clickregion. > > LaszloView - if clickregion capability is true, make the view clickable if > needed then call sprite.setClickRegion() with the appropriate resource ID. > > compiler/* - Remove compiler special casing since click masks are applied at > runtime. > > Tests: See LPP-9089.zip > > Files: > M WEB-INF/lps/lfc/kernel/swf/LzSprite.as > M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js > M WEB-INF/lps/lfc/kernel/swf9/LzSprite.as > M WEB-INF/lps/lfc/views/LaszloView.lzs > M WEB-INF/lps/server/src/org/openlaszlo/compiler/ObjectWriter.java > M WEB-INF/lps/server/src/org/openlaszlo/compiler/DHTMLWriter.java > M WEB-INF/lps/server/src/org/openlaszlo/compiler/ViewCompiler.java > M WEB-INF/lps/server/src/org/openlaszlo/compiler/NullWriter.java > M WEB-INF/lps/server/src/org/openlaszlo/compiler/SWFWriter.java > M WEB-INF/lps/server/src/org/openlaszlo/compiler/SWF9Writer.java > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100604-maxcarlson-Q.tar
