Comments:
1) We don't _have_ to follow the Java way of 1-class/1-file, especially for
small, related classes.
2) LzIdle/notify could be simplified. There's no need for the `registered`
property, since `notify` is guaranteed to only be called when `ready` changes
state, you could just say `if (ready) { ... addCallback ... } else { ...
removeCallback ... }`
Approved.
On 2010-06-19, at 13:00, Max Carlson wrote:
> Change 20100619-maxcarlson-X by maxcarl...@friendly on 2010-06-19 09:56:02 PDT
> in /Users/maxcarlson/openlaszlo/trunk-clean
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Add notifying event mechanism
>
> Bugs Fixed: LPP-8119 - Make a generic 'notifying event' for more efficient
> runtime callback handling
>
> Technical Reviewer: ptw
> QA Reviewer: hminsky
>
> Details: I decided to break this up into several changesets.
> LzNotifyingEvents can be used for text links and text scrolling, in addition
> to LzIdle.
>
> LzIdle - LzIdleEvent extends LzNotifyingEvent.
>
> LzDeclaredEvent - Allow arbitrary event classes, break into its own file.
>
> core/Library - Include LzDeclaredEvent.
>
> LzDefs - Move LzDeclaredEvent to its own file.
>
> LaszloEvents - Look up class to be instantiated in LzDeclaredEvent.actual,
> otherwise default to LzEvent.
>
> LzNotifyingEvent - Add generig 'notifying event' class.
>
> events/Library - Include LzNotifyingEvent.
>
> Tests: LzIdle, all apps run as before.
>
> Files:
> M WEB-INF/lps/lfc/services/LzIdle.lzs
> A WEB-INF/lps/lfc/core/LzDeclaredEvent.lzs
> M WEB-INF/lps/lfc/core/Library.lzs
> M WEB-INF/lps/lfc/core/LzDefs.lzs
> M WEB-INF/lps/lfc/events/LaszloEvents.lzs
> A WEB-INF/lps/lfc/events/LzNotifyingEvent.lzs
> M WEB-INF/lps/lfc/events/Library.lzs
>
> Changeset:
> http://svn.openlaszlo.org/openlaszlo/patches/20100619-maxcarlson-X.tar
