How about some comments: 1) LzLibraryCleanup has to be dynamic because it is extending Node and Node's protocols require them to be dynamic.
2) A comment in ImportCompiler about why you have to pass the compile-time constants to the ObjectWriter Otherwise, approved for Technical Review. On 2010-07-01, at 16:53, Henry Minsky wrote: > Change 20100701-hqm-n by [email protected] on 2010-07-01 16:44:45 EDT > in /Users/hqm/openlaszlo/trunk-diamond > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Import tag with Stage="defer" and debug set to false will NOT > compile in 5.0.x and 4.8.0 Flash 9 and 10. > > New Features: > > Bugs Fixed: LPP-9168, LPP-9142 > > Technical Reviewer: ptw > QA Reviewer: max > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Overview: > > there were a couple of bugs in compiling 'snippets' for SWF10 > > > also fix for Import tag throws flash error with Stage="defer". Imported > classes aren't available for instantiation unless hardcoded in XML. > > > Details: > > lfc/kernel/LzLibraryCleanup.lzs: > declare LzLibraryCleanup dynamic, so that applyArgs doesn't complain when it > probes for 'libname' > (even though it's not actually an attribute, there's a setter for it, we > should have some policy about that) > > SWF9External.java: > > There was a bug when I refactored the args to SWF9 backend. > Behavior should be similar to an app; when compiling a SNIPPET use mxmlc and > producea .swf, except for without the preloader. > > > ImportCompiler.java: > Initialize compileTimeConstants properly > > Tests: > > from LPP-9168 bug report test case: > Hello World appears when you click the button, and no Flash debugger errors > > test/snippets/import-class-and-view-direct?lzr=swf10 > etst/snippets/import-dataset.lzx?lzr=swf10 > test/smoke/smokecheck in swf10 > > Files: > M WEB-INF/lps/lfc/kernel/LzLibraryCleanup.lzs > M WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java > M WEB-INF/lps/server/src/org/openlaszlo/compiler/ImportCompiler.java > > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100701-hqm-n.tar
