So, you are making extra sure, by doing it twice? On 2010-07-06, at 14:39, Max Carlson wrote:
> On 7/6/10 6:04 AM, P T Withington wrote: >> Why the duplicate test: > > It's there to ensure the color is being accurately converted from hex string > format... > >>> assertEquals(8323199, LzColorUtils.fromhsv(300, 1, .5), >>> "Convert fromhsv "); >> >> ? >> >> Otherwise, approved. >> >> On 2010-07-03, at 23:39, Max Carlson wrote: >> >>> Change 20100703-maxcarlson-l by maxcarl...@friendly on 2010-07-03 20:36:06 >>> PDT >>> in /Users/maxcarlson/openlaszlo/trunk-clean >>> for http://svn.openlaszlo.org/openlaszlo/trunk >>> >>> Summary: Make LzColorUtils.tohsv() more robust >>> >>> Technical Reviewer: hminsky >>> QA Reviewer: ptw >>> >>> Details: Ensure tohsv() accepts any color type. >>> >>> Tests: test/lfc/lzunit-lzutils.lzx passes with the patch >>> >>> Files: >>> M test/lfc/lzunit-lzutils.lzx >>> M WEB-INF/lps/lfc/services/LzUtils.lzs >>> >>> Changeset: >>> http://svn.openlaszlo.org/openlaszlo/patches/20100703-maxcarlson-l.tar >>
