Approved, although I would really like it if we renamed the table to 'customSetter' and the method to 'invokeCustomSetter' (or something along that line).
It seems really whacky that you return `false` from skipSetter to skip. On 2010-07-03, at 12:15, Max Carlson wrote: > Change 20100703-maxcarlson-u by maxcarl...@friendly on 2010-07-03 09:10:37 PDT > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Keep CSS3 transitions from running until after init time > > Bugs Fixed: LPP-9020 -Support CSS3 transitions > > Technical Reviewer: hminsky > QA Reviewer: ptw > > Details: LzNode - __skipSetter() returns true if ! inited, allowing the > default setter to run. > > LzEventable - Change __skipSetter() to allow conditionally skipping the > setter depending on the return value. > > Tests: The button doesn't animate until it's clicked: > <canvas> > <button transition="x 2s" x="100" onclick="this.setAttribute('x', > 200)">Hello Laszlo!</button> > </canvas> > > Files: > M WEB-INF/lps/lfc/core/LzNode.lzs > M WEB-INF/lps/lfc/core/LzEventable.lzs > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100703-maxcarlson-u.tar
