Issues:
1) I don't like the idea of making this a component if it has to call private
API's (e.g., __LzApplyArgs). That seems like a bad road to start down. I
can't tell if it really needs to do that, or that's just the way it was
written. Is there a way to write this without using private API's?
2) I don't understand this comment in layout.lzx#94:
> // ignore special default value of 2 until __parentInit();
especially given this change in construct:
> // set as early as possible - can't wait for setter to be called
> this.locked = args.locked;
Does every layout get a `locked` init arg?
Questions:
1) Is it a bug that LPS components have to explicitly include other components
rather than rely on auto-includes?
2) What's this about?
> <script>
> if ($as3) {
> } else {
> LzLayout = lz.layout; // publish for compatibility
> }
> </script>
I thought the old names would have been deprecated long enough now that we
would not need them?
On 2010-07-09, at 16:25, Max Carlson wrote:
> Change 20100709-maxcarlson-v by maxcarl...@friendly on 2010-07-09 13:21:08 PDT
> in /Users/maxcarlson/openlaszlo/trunk-clean
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Move layout baseclass from the LFC to an LZX include
>
> Bugs Fixed: LPP-9180 - Move non-essential parts of the LFC to LZX includes
> (partial)
>
> Technical Reviewer: ptw
> QA Reviewer: hminsky
>
> Details: LaszloLayout,Library - Move to lps/components/utils/layouts/,
> rewrite to use LZX syntax
>
> lzx-autoincludes.properties - Add layout.lzx
>
> utils/layouts/* - Explicitly include layout.lzx
>
> Tests: Component sampler and debugger run as before.
>
> Files:
> D WEB-INF/lps/lfc/controllers/LaszloLayout.lzs
> M WEB-INF/lps/lfc/controllers/Library.lzs
> M WEB-INF/lps/misc/lzx-autoincludes.properties
> M lps/components/utils/layouts/library.lzx
> M lps/components/utils/layouts/wrappinglayout.lzx
> M lps/components/utils/layouts/stableborderlayout.lzx
> M lps/components/utils/layouts/constantlayout.lzx
> M lps/components/utils/layouts/simplelayout.lzx
> M lps/components/utils/layouts/reverselayout.lzx
> A + lps/components/utils/layouts/layout.lzx
> M lps/components/utils/layouts/resizelayout.lzx
> M lps/components/utils/layouts/constantboundslayout.lzx
> M lps/components/utils/layouts/simpleboundslayout.lzx
>
> Changeset:
> http://svn.openlaszlo.org/openlaszlo/patches/20100709-maxcarlson-v.tar
