Change 20100709-maxcarlson-M by maxcarl...@friendly on 2010-07-09 10:25:23 PDT
in /Users/maxcarlson/openlaszlo/trunk-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: UPDATED: Move selection managers and command to lzx includes
Bugs Fixed: LPP-9180 - Move non-essential parts of the LFC to LZX includes
(partial)
Release Notes: command, selectionmanager and dataselectionmanager have been
moved out of the LFC and into LZX auto includes, found at
lps/components/utils/. Any other components that use the autoinclude mechanism
will need to be updated to manually include dataselectionmanager.lzx,
selectionmanager.lzx and/or command.lzx
Technical Reviewer: ptw
QA Reviewer: hminsky
Details: Updated to address Andre's comments:
- Some additional release notes are required. For example where to find the
selection managers, in which cases explicit includes are now necessary, etc.
Done.
- dataselectionmanager uses lfc-internal methods (e.g. datapath#setSelected,
DataElement#sel), so special care needs to be taken to document that now
non-lfc classes use these fields/methods
I added notes to the relevant fields to LzDataNode and LzDatapath and marked
them public.
- Why is as3 excluded here?
> +<script>
> +if ($as3) {
> +} else {
> + var LzSelectionManager = lz.selectionmanager; // publish for
> compatibility
> +}
> +</script>
I removed those.
- "lastRangeStart" not "lastRangeStar"
> + <!---
> + @access private
> + -->
> + <attribute name="lastRangeStar"/>
Fixed.
- Why did you remove the "@type *" doc-comment?
> + <!---
> + @access private
> + -->
> + <attribute name="lastRangeStar"/>
Fixed.
- Why did you remove the return types for all methods? For example:
> + <method name="__LZaddToSelection" args="d:*, o:LzView">
instead of
<method name="__LZaddToSelection" args="d:*, o:LzView" returns="void">
Fixed.
- I'm not sure that this ("o /*:LzView*/") works for lzx2js2doc.xsl (see
"processargs" template), have you tested this, that means did you rebuild the
reference guide?
> + <method name="isSelected" args="o /*:LzView*/">
It _should_ work, but if this breaks the reference guide I'll address it.
- I'd prefer to keep the CDATA start at the end of the line:
> + <method name="__LZaddToSelection" args="d:*, o:LzView">
> + <![CDATA[
> + ]]>
> + </method>
like:
<method name="..." args="..."><![CDATA[
...
]]></method>
Unfortunately we don't seem to have a consistent code style for CDATA blocks,
both types (CDATA directly following the <method> element, and CDATA on the
next line) are used in the components directory at the same frequency.
Done.
- This is a clear public API change, also see the related JIRA bugs: LPP-4982,
LPP-7814
> -var keys = null;
> [...]
> +<attribute name="key" value="null"/>;
- Both methods are now broken, but see above about the key/keys issue:
> +<method name="destroy">
> var oldKeys = this.keys;
> +<method name="keysToString">
> + <