Did you test calling nodePath in a non-debug build?

It seems that at least this line should remain inside `if ($debug)`:

>     if (node === Debug.inspectContext) { return '.'; }

Otherwise, approved.

On 2010-07-16, at 20:58, Max Carlson wrote:

> Change 20100716-maxcarlson-z by maxcarl...@friendly on 2010-07-16 17:44:30 PDT
>    in /Users/maxcarlson/openlaszlo/trunk-clean
>    for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Add API to capture all mouse and keyboard events
> 
> New Features: LPP-9200 - Add way to capture all mouse and keyboard events
> 
> Technical Reviewer: ptw
> QA Reviewer: hminsky
> 
> Details: LzGlobalMouse - Add mouseevent event that sends all mouse events.
> 
> LzKeys - Add onkeyevent event that sends all keyboard events.
> 
> LzNode - Move nodePath out of the $debug block so it's always available.
> 
> Tests: IWFM! 
> 
> Files:
> M       WEB-INF/lps/lfc/services/LzGlobalMouse.lzs
> M       WEB-INF/lps/lfc/services/LzKeys.lzs
> M       WEB-INF/lps/lfc/core/LzNode.lzs
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20100716-maxcarlson-z.tar


Reply via email to