Not approved, because it's still too naive and contains bugs like changing "canvas.setAttribute('title', t i t l e)" to "canvas.setAttribute('title', title)". There are also other white space chars, I'd add at least the most most common one: ' ', '\t', '\r', '\n'.

On 7/23/2010 4:53 AM, Max Carlson wrote:
Change 20100722-maxcarlson-r by maxcarl...@friendly on 2010-07-22 19:41:19 PDT
     in /Users/maxcarlson/openlaszlo/trunk-clean
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix callMethod() argument processing to handle strings properly

Bugs Fixed: LPP-9228 -  lz.embed.foo.callMethod() doesn't handle strings 
properly

Technical Reviewer: hminsky
QA Reviewer: ptw

Details: Improve handling of strings in __unpackList() - instead of naively 
splitting on commas, use a string tokenizer.

Tests: Typing lz.embed.callMethod("canvas.setAttribute('title', 
\"string,,with,commas\")") into firebug and doesn't fail with an argument count 
mismatch with swf10 app.

Files:
M       WEB-INF/lps/lfc/services/LzUtils.lzs

Changeset: 
http://svn.openlaszlo.org/openlaszlo/patches/20100722-maxcarlson-r.tar


Reply via email to