Yaah, I realized that just after I woke up. Dreaming in code again...
Regards,
Max Carlson
OpenLaszlo.org
On 7/27/10 8:44 AM, [email protected] wrote:
Hi Max,
I re-opened LPP-9241 because I found a problem when there is a single
space after a command and the next quoted string argument. I put more
details in the jira report.
Thanks!
Phil
On Mon, Jul 26, 2010 at 9:47 PM, Max Carlson wrote:
Change 20100722-maxcarlson-r by maxcarl...@friendly on 2010-07-22
19:41:19 PDT
in /Users/maxcarlson/openlaszlo/trunk-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: UPDATED: Fix callMethod() argument processing to handle
strings properly
Bugs Fixed: LPP-9228 - lz.embed.foo.callMethod() doesn't handle
strings properly, LPP-9241 - HTML SWF: You cannot have a string with a
comma when using iframemanager#asyncCallback()
Technical Reviewer: promanik
QA Reviewer: [email protected]
Details: Updated to address Andre's comments:
Not approved, because it's still too naive and contains bugs like
changing "canvas.setAttribute('title', t i t l e)" to
"canvas.setAttribute('title', title)". There are also other white
space chars, I'd add at least the most most common one: ' ', '\t',
'\r', '\n'.
This change should take care of that.
Improve handling of strings in __parseArgs() - instead of naively
splitting on commas, use a string tokenizer.
Tests: Typing lz.embed.callMethod("canvas.setAttribute('title',
\"string,,with,commas\")") into firebug and doesn't fail with an
argument count mismatch with swf10 app. canvas.setAttribute('title', t
i t l e) also comes through as-is.
Files:
M WEB-INF/lps/lfc/services/LzUtils.lzs
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20100722-maxcarlson-r.tar
