*// prefer adding scripts to the body - it's better for performance*
- var el = document.getElementsByTagName("body")[0] ||
document.getElementsByTagName("head")[0]
- el.appendChild(script);
+ addto.appendChild(script);
And the comment should be moved, too.
On 8/3/2010 7:22 PM, Max Carlson wrote:
Change 20100803-maxcarlson-E by [email protected] on 2010-08-03
10:01:31 PDT
in /Users/maxcarlson/openlaszlo/trunk-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Make html.callJavascript() more robust
Bugs Fixed: LPP-9261 - The callJavascript method of the html component does not
call methods
Technical Reviewer: promanik
QA Reviewer: dwheeler
Details: components/extensions/html - Don't call html setter unless there's a
valid iframeid, use safe lookup to eliminate warnings in swf8.
embednew - Prevent potential memory leak in IE.
iframemanager - Add timeout for onload events to allow loaded HTML to parse.
Simplify __destroy() to use DOM APIs and clean up extra container div in IE.
Add firebug console warnings for failed callJavascript() calls.
examples/extensions/html.lzx - Rearrange buttons, add test for html setter.
Tests: See updated testcase at LPP-9261. Also see examples/extensions/html.lzx
- inspecting the DOM after clicking Destroy shows no iframes. No more warnings
in swf8
Files:
M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M lps/components/extensions/html.lzx
M lps/includes/source/embednew.js
M lps/includes/source/iframemanager.js
M examples/extensions/html.lzx
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20100803-maxcarlson-E.tar
