Approved!

Regards,
Max Carlson
OpenLaszlo.org

On 8/7/10 3:39 AM, André Bargull wrote:
Change 20100807-bargull-q7Z by barg...@bargull02 on 2010-08-07 12:27:20
in /home/anba/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix regular expression in compiler and re-use patterns if possible

Bugs Fixed: LPP-9103 (Wrong patterns in CanvasCompiler and NodeModel)

Technical Reviewer: max
QA Reviewer: (pending)

Details:
CanvasCompiler:
- changed pattern to accept the right values
FontInfo:
- changed pattern to accept white-space after $when
NodeModel:
- removed unused pattern to detect "$(...)" constraints
- fixed quoted identifier pattern to ensure strings start and ends with
the same quote character

Patterns are now compiled once and re-used.


Tests:

Files:
M WEB-INF/lps/server/src/org/openlaszlo/compiler/CanvasCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/FontInfo.java

Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20100807-bargull-q7Z.tar


Reply via email to