Don's comment from http://www.ietf.org/rfc/rfc1738.txt implies that [] would
not be permissible.
Quoting from elsewhere in that same spec:
> Other characters are unsafe because
> gateways and other transport agents are known to sometimes modify
> such characters. These characters are "{", "}", "|", "\", "^", "~",
> "[", "]", and "`".
So, I think we want (), and whatever Max saw is some browser or something being
hyper-conservative and encoding () even though the spec specifically says it
does not need to.
On 2010-08-17, at 15:49, Henry Minsky wrote:
> I wonder if we need to use something other than '( )'.
> How about square brackets?
>
> If I use square brackets, it doesn't do that... so options would look like
>
> lzoptions=runtime[dhtml],wrapper[html],debug[false],proxy[true]
>
>
>
>
>
> On Tue, Aug 17, 2010 at 3:32 PM, Max Carlson <[email protected]> wrote:
>
>> Not approved. You're missing some files:
>>
>>
>> http://localhost:8080/trunk-clean/test/hello.lzx?lzoptions=lzr%28swf10%29,flexversion%2810.1%29
>>
>> fails:
>>
>> Compilation Errors
>> org.openlaszlo.sc.CompilerError: tunit/line unknown: , in line:
>> /Users/maxcarlson/openlaszlo/trunk-clean/WEB-INF/frameworks/flex-config.xml(53):
>> Error: unable to open 'libs/player/10.1/playerglobal.swc'
>> </external-library-path>
>>
>> Also, notice the funny %28 %29 encoding that just happened when I
>> cut/pasted the URL... Seems like something that we may need to deal with.
>>
>>
>> On 8/17/10 11:34 AM, Henry Minsky wrote:
>>
>>> Change 20100817-hqm-8 by [email protected] on 2010-08-17 11:46:24 EDT
>>> in /Users/hqm/openlaszlo/trunk-clean
>>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>>
>>> Summary: add unified 'lzoptions' support
>>>
>>> New Features:
>>>
>>> Bugs Fixed: LPP-3479
>>>
>>> Technical Reviewer: ptw
>>> QA Reviewer: max
>>> Doc Reviewer: (pending)
>>>
>>> Documentation:
>>>
>>> unified compiler options for an app can be specified by a new query
>>> arg, lzoptions, of the form
>>>
>>> ?lzoptions=runtime(dhtml),wrapper(html),debug(false),proxy(true)
>>> For boolean options, we default that if they are present they
>>> are true, if not they are false so:
>>> ?lzoptions=runtime(dhtml),wrapper(html),proxy
>>> would be the same as the above.
>>>
>>> multiple comma separated values can be passed in args list,
>>> e.g.,
>>>
>>> ?lzoptions=runtime(swf10),package(widget,android)
>>>
>>> Release Notes:
>>>
>>> Overview:
>>>
>>> + Added "flexversion" compiler option to select between flash 10.0 and
>>> 10.1
>>>
>>> + Added support for passing compiler options in unified "lzoptions" string
>>>
>>> + modified "lzc" command line interpreter to accept 'flexversion' arg
>>>
>>> Note: This patch doesn't yet let you set runtime to DHTML using
>>> 'lzoptions', because embednew.js needs to be modified how to parse the
>>> lzoptions string format in order decode the options like 'runtime'
>>> that are currently passed as separate query args.
>>>
>>> Loading lzx apps via the browser for swf runtimes happens to work at
>>> the moment because swf is the default runtime, and the wrapper passes
>>> the lzoptions through to the LPS server.
>>>
>>> Details:
>>>
>>> + I did not modify "lzc" command line processor to accept the new
>>> lzoptions
>>> format yet. It still requires the old style discrete flags.
>>>
>>> Tests:
>>> smokecheck in swf10
>>> test/lfc/data in swf10
>>>
>>> TLF bidi tests
>>> test/tlf/text-test.lzx?lzr=swf10
>>> test/tlf/focus-input.lzx?lzr=swf10
>>>
>>> fetching test/hello.lzx using lzoptions
>>>
>>> http://127.0.0.1:8080/trunk-clean/test/hello.lzx?lzoptions=lzr(swf10),flexversion(10.1)<http://127.0.0.1:8080/trunk-clean/test/hello.lzx?lzoptions=lzr%28swf10%29,flexversion%2810.1%29>
>>>
>>> confirm by inspection of as files in compiler apache temp build
>>> directory 'lzswf9', that flex compiler is getting passed the arg
>>> "-target-player=10.1":
>>>
>>> /openlaszlo/lib/apache-tomcat-5.5.29/temp/lzswf9/Users/hqm/openlaszlo/trunk-clean/test/build/hello/build.sh
>>>
>>> Files:
>>> M WEB-INF/lps/config/lps.properties
>>> M WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java
>>> M WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
>>> M WEB-INF/lps/server/src/org/openlaszlo/server/LPS.java
>>> M
>>> WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderCompile.java
>>> M
>>> WEB-INF/lps/server/src/org/openlaszlo/compiler/CompilationEnvironment.java
>>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/Compiler.java
>>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/Main.java
>>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/SWF9Writer.java
>>> M lps/includes/source/embednew.js
>>>
>>>
>>> Changeset:
>>> http://svn.openlaszlo.org/openlaszlo/patches/20100817-hqm-8.tar
>>>
>>
>> --
>> Regards,
>> Max Carlson
>> OpenLaszlo.org
>>
>
>
>
> --
> Henry Minsky
> Software Architect
> [email protected]
