Much better - approved!
Regards,
Max Carlson
OpenLaszlo.org
On 8/21/10 1:50 PM, P T Withington wrote:
I updated the change to not use the `in` operator for detecting attributes in
nodes in as3. Want to try again?
On 2010-08-20, at 18:49, Max Carlson wrote:
Whoops - sorry... I just realized this change breaks mouseover actions and
leaves the scrollbars squared off in swf10 for
http://svn.lzxpatterns.com/components/trunk/demos/house.lzx
Regards,
Max Carlson
OpenLaszlo.org
On 8/20/10 5:20 AM, P T Withington wrote:
Change 20100819-ptw-r by [email protected] on 2010-08-19 20:53:16 EDT
in /Users/ptw/OpenLaszlo/trunk-3
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Improve dynamic CSS
Bugs Fixed: LPP-9305 Warning appears in debugger when applying CSS dynamically
if a parent node contains a true/false style
Technical Reviewer: [email protected] (pending)
QA Reviewer: [email protected] (pending)
Details:
dynamic.lzx: Re-worked to verify that applying and removing a
style to an attribute with a default value correctly overrides and
restores the default.
LzCSSStyle: Need to use `in` to detect applicability of an
attribute selector, since the attribute may be (void 0) when
dependencies are computed. Be sure to compute all dependencies
before the early return from _compoundSelectorApplies.
LzDebug: Update documentation in explainStyleBindings. Use new
CSS caches.
LzNode: Add CSS maps for attribute to CSS property and attribute
to CSS fallback. Remove unnecessary property to attribute map.
Fix __reapplyCSS to notice when a property is no longer applicable
or newly applicable in addition to when it has changed value.
When any of these happen, reapply the style binding or fallback
value, as appropriate. __LZstyleBindAttribute updates the new
maps.
Tests:
Test case from bug,
http://svn.lzxpatterns.com/components/trunk/demos/house.lzx,
improved dynamic test case
Files:
M test/style/dynamic/dynamic.lzx
M WEB-INF/lps/lfc/services/LzCSSStyle.lzs
M WEB-INF/lps/lfc/debugger/LzDebug.lzs
M WEB-INF/lps/lfc/core/LzNode.lzs
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100819-ptw-r.tar
