Nah, you're right. I'll leave the other changes as-is for the (slight)
speedup the afford. Don't worry about this change...
Regards,
Max Carlson
OpenLaszlo.org
On 8/21/10 1:35 PM, P T Withington wrote:
As I said in my other message, this is an optimization only if the LHS of `is`
is null. In every other case, it is a disoptimization. So I don't buy it.
What am I missing?
On 2010-08-21, at 15:56, Max Carlson wrote:
Change maxcarlson-20100821-D8q by maxcarl...@friendly on 2010-08-21 12:53:48 PDT
in /Users/maxcarlson/openlaszlo/trunk-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Make is operator slightly more efficient
Bugs Fixed: LPP-6892 - Generated File Sizes baseline complete; Performance
Tuning ongoing
Technical Reviewer: ptw
QA Reviewer: hminsky
Details: LzNode - Remove redundant tests before 'is' operator.
JavascriptGenerator - Test to see if the property exists before running 'is'
tests.
Tests: All apps run as before, smokecheck
Files:
M WEB-INF/lps/lfc/core/LzNode.lzs
M WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/maxcarlson-20100821-D8q.tar
