Change hqm-20100910-lPf by [email protected] on 2010-09-10 16:21:21 EDT
    in /Users/hqm/openlaszlo/trunk-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: pass flex compiler backend options as single string

New Features:

Bugs Fixed: LPP-3479

Technical Reviewer: ptw
QA Reviewer: max
Doc Reviewer: (pending)

Documentation:

Release Notes:

Overview:

I wanted to make it possible to pass an arbitrary set of key/values to the flex 
compiler backend, and have
them decoded there, rather than making the LPS server and dev console know 
about them individually.

I  had originally had this idea that the lzoptions  handling API mechanism 
would automatically
turn multiple values for an option into a List, but I have changed it instead 
to pass multiple values as the verbatim
string that the user supplied (e.g., "foo(bar,baz,blah)" will have the
string value "bar,baz,blah"). There are just too many places in the
dev console, server, and embed.js library which really want to treat
query args as just strings, and not lists in the case of multiple values. The 
final client can decode the value
however it likes, such as the SWF10 backend, which parses out the flex
options.

Details:
    
dev-console now  URI-encodes the query values in the URL it constructs, for 
safety, since we're allowing
passing more liberal values in the lzoptions values.

Tests:

command line lzc:

lzc --flex-options=version=10.1,air --runtime=swf10 demos/lzpix/app.lzx 

verify that the flex compiler is called with 
-load-config=/Users/hqm/openlaszlo/trunk-clean/WEB-INF/frameworks/air-config.xml
and
-target-player=10.1


Run dev console and see that URL of the form
    
http://localhost:8080/trunk-clean/demos/lzpix/app.lzx?lzoptions=proxied%28true%29%2Cflexoptions%28version%3D10.1,air%29%2Cruntime%28swf10%29

and verify that the app compiles with target-player 10.1 and air config (need 
to inspect the tomcat server/s temp/lzswf9/.../build.sh to see what
command line it sent to flex)


Files:
M       WEB-INF/lps/server/src/org/openlaszlo/utils/LZHttpUtils.java
M       WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java
M       WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
M       
WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderCompile.java
M       
WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderAPP_CONSOLE.java
M       
WEB-INF/lps/server/src/org/openlaszlo/compiler/CompilationEnvironment.java
M       WEB-INF/lps/server/src/org/openlaszlo/compiler/Main.java
M       WEB-INF/lps/server/src/org/openlaszlo/compiler/SWF9Writer.java
M       lps/includes/source/embednew.js
M       lps/admin/dev-console.lzx.swf
M       lps/admin/dev-console.lzx
M       lps/admin/lps/includes/lfc/LFCdhtml.js
M       lps/admin/dev-console.lzx.js

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/hqm-20100910-lPf.tar

Reply via email to