Looks good to me. On 2010-09-15, at 15:59, Max Carlson wrote:
> Change 20100915-maxcarlson-w by maxcarl...@friendly on 2010-09-15 11:18:43 PDT > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: DHTML: Fix multiline text > > Bugs Fixed: LPP-9268 - DHTML: padding is not subtracted from width/height for > texts > > Technical Reviewer: [email protected] > Technical Reviewer: ptw > QA Reviewer: hminsky > > Details: I'm going to check this in because it fixes a regression. > > LzSprite - Set correct default CSS for single-line text. > > LzTextSprite - Update cache value to reflect CSS default for single-line > text. Remove multiline property. Remove redundant code in setMultiline(), > add comment to setSelectable(), shorten setResize(). > > LzText - Add comment about setSelectable() needing to be called once in > dhtml, add guards to prevent duplicate calls in set_multiline and set_resize, > call with the correct args in construct() instead of setting a property then > calling which breaks the guards. > > Tests: examples/components/edittext_example.lzx shows text in the window > correctly, debugger scrolling works again, test/lztest/lztest-textheight.lzx > runs correctly across runtimes. > > Files: > M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js > M WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js > M WEB-INF/lps/lfc/views/LzText.lzs > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100915-maxcarlson-w.tar
