I can see why you were hacking the value after the fact. This should be
more robust, but it feels wrong conditionalizing on typestring ==
'click'. But it works - I think this is fine. A few nits:
typestring == 'click')
could be
typestring === 'click')
Do you really need the separate 'quirks' var? It's only being looked up
once:
+ var quirks = this.quirks;
+ var copyclip = true;
This has bad indentation:
- this.__copystyles(sprite.__LZdiv, newdiv);
+
+ this.__copystyles(sprite.__LZdiv, newdiv, copyclip);
+ if (quirks.dont_clip_clickdivs && typestring == 'click') {This
isn't valid JS:
-LzSprite.prototype.__copystyles = function(from, to) {
+LzSprite.prototype.__copystyles = function(from, to, copyclip = true) {
Can you change to:
LzSprite.prototype.__copystyles = function(from, to, copyclip) {
copyclip = copyclip || true;
Otherwise approved!
On 9/22/10 9:04 PM, Henry Minsky wrote:
Change hqm-20100922-M2l by [email protected] on 2010-09-22 23:20:39 EDT
in /Users/hqm/openlaszlo/trunk-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: fix for DHTML clickdivs in Opera
New Features:
Bugs Fixed: LPP-9380, LPP-9382
Technical Reviewer: max
QA Reviewer: (pending)
Doc Reviewer: (pending)
Documentation:
Release Notes:
Overview:
Details:
always remove clipping from clickdivs in Opera
Tests:
tabsliders and menus work in:
examples/components/component_sampler.lzx?lzr=dhtml
Files:
M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/hqm-20100922-M2l.tar
