On 2010-12-06, at 08:01, Henry Minsky wrote: > approved. I see differing border widths now in the test case. > > So the name "_space" was being shadowed by another mixin?
Yes. One of the dangers of working with power tools. We allow a subclass to re-specify an attribute with a different initial value, so there is no warning generated. I suppose we could say that in mixins you need to specify override to get that and warn otherwise. The _real_ way this should be done, _space should be a class constant, and should only be visible to the individual mixin component, but I'm pretty sure that does not work across runtimes? I guess I should check... On Mon, Dec 6, 2010 at 10:12 AM, P T Withington <[email protected]> wrote: > >> Change ptw-20101206-zOX by [email protected] on 2010-12-06 06:59:19 PST >> in /Users/ptw/OpenLaszlo/trunk-3/my-apps/newcomponents >> for http://svn.lzxpatterns.com/components/trunk >> >> Summary: Fix borderradius lossage >> >> Bugs Fixed: LPP-9564 borderwidth broken >> >> Technical Reviewer: [email protected] (pending) >> QA Reviewer: [email protected] (pending) >> >> Details: >> Rename _space to _comma (which it really is), because it was >> clobbering the definition of _space needed or border* parsing >> >> Tests: >> testbtn in demos/ptw.lzx has varying-width borders again >> >> Files: >> M lib/gradientfill.lzx >> >> >> Changeset: >> http://svn.openlaszlo.org/openlaszlo/patches/ptw-20101206-zOX.tar >> > > > > -- > Henry Minsky > Software Architect > [email protected]
