Agree with Tucker. Can we switch on the incremental compilation automatically by default when on debug mode?
-Fred 2011/1/4 Henry Minsky <[email protected]> > > > On Mon, Jan 3, 2011 at 12:57 PM, Max Carlson <[email protected]>wrote: > >> Not approved. I do see improved compile times in swf10 - very cool! >> >> The DHTML version of the dev console fails when I click the 'Compile' >> button: >> cb_incremental is not defined >> [Break On This Error] var $0=rg_runtime.value;var >> $1=cb_debu...lzoptions"];var $a=null;if($9!=null){ >> >> I notice that the 'incremental' checkbox doesn't stay checked after I hit >> 'Compile', even though the URL is: >> ?lzoptions=proxied(true)%2Cruntime(swf10)%2Cincremental(true) >> > > I'll fix that by taking Tucker's suggestion and put the incremental option > in all runtimes. > >> >> Also, if I start with ?lzr=swf10 then hit 'Compile' the URL looks like >> this: >> ?lzr=swf10&lzoptions=runtime(swf10)%2Cincremental(true)%2Cproxied(true) >> >> >From that point forward, changing the lzr=xxx portion of the URL doesn't >> change the runtime. It seems like the dev console should remove lzr= when >> rewriting to use the new syntax, lest folks become confused. > > > Yes, it's a bug to have both lzr= and lzoptions=runtime(...) in the same > query args string. I'll have it strip the lzr, and any other redundant > options it sees (like 'debug') > > > >> >> >> On 1/2/11 9:04 PM, Henry Minsky wrote: >> >>> Change hqm-20110103-jjl by [email protected] on 2011-01-03 00:00:08 >>> EST >>> in /Users/hqm/openlaszlo/trunk-diamond >>> for http://svn.openlaszlo.org/openlaszlo/trunk >>> >>> Summary: fix for swf10 incremental compilation mode >>> >>> New Features: >>> >>> Bugs Fixed: >>> >>> Technical Reviewer: ptw >>> QA Reviewer: max >>> Doc Reviewer: (pending) >>> >>> Documentation: >>> >>> Release Notes: >>> >>> Overview: >>> >>> >>> Details: >>> >>> The flex incremental compiler mode only works if the app.swf remains from >>> the last compile. We were deleting >>> it on each compile, to incremental mode had no effect. >>> >>> SWF9External.java: preserve old app.swf if compiling in incremental mode >>> >>> >>> Tests: >>> >>> + from lzc: >>> 1. compile an app from lzc, with the "--incremental" flag >>> 2. touch or modify an lzx file, and call lzc again with the >>> --incremental flag. recompile should be significantly faster (25% or more) >>> >>> >>> + via server: >>> compile an app via the server , check the "incremental" box in the dev >>> console >>> (or add "lzoptions=incremental" or "lzoptions=incremental(true)" to >>> URL query args) >>> >>> touch or modify an lzx source file >>> >>> reload app, recompile should be noticably faster (25% or more) >>> >>> >>> >>> Files: >>> M WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java >>> M >>> WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderCompile.java >>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/Compiler.java >>> M lps/admin/dev-console.lzx.swf >>> M lps/admin/dev-console.lzx >>> M lps/admin/lps/includes/lfc/LFCdhtml.js >>> M lps/admin/dev-console.lzx.js >>> >>> Changeset: >>> http://svn.openlaszlo.org/openlaszlo/patches/hqm-20110103-jjl.tar >>> >> > > > -- > Henry Minsky > Software Architect > [email protected] > > > -- captain
