LaszloView.lzs:
- description from setPlay() is now lost, b/c there isn't actually a "play" attribute
(just the "play" method)
Hrm, not sure what to do about this one. Perhaps deprecate play()?
But see also LPP-7273 (and the related LPP-392, LPP-4172) which proposes
to remove the "play" attribute in favour of the play() method. The
"play" attribute doesn't seem to be documented at all since some time,
at least it's not included in the reference for OL 4.6 and later.
On 1/9/2011 6:19 AM, Max Carlson wrote:
Change maxcarlson-20110108-NWq by maxcarl...@friendly on 2011-01-08 21:06:51 PST
in /Users/maxcarlson/openlaszlo/trunk-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Update doc comments
Bugs Fixed: LPP-9625 - Remove @deprecated methods and properties from the LFC,
LPP-7401 - setter-documentation
Technical Reviewer: [email protected]
QA Reviewer: hminsky
Details: I'm going to check this in. Update to address Andre's comments:
LzContextMenu.lzs:
- please indent the lines
Done.
- please update LPP-6629
Done.
- "Sets the delegate which will be called when a menu item is selected. An onselect
event is also sent."
=> "Sets the delegate which will be called when the menu is opened. An onmenuopen event is also
sent." (This is for<contextmenu>, only<contextmenuitem> sends an "onselect" event!)
Done,
LzDataNode.lzs:
- test\lfc\data\stringxml.lzx, test\lztest\lztest-lzdataelement.lzx,
test\lztest\lztest-lzdatanode.lzx, test\lztest\lztest-lzdatatext.lzx still refer to
"LzDataNode.stringToLzData(...)"
Done.
basecombobox.lzx:
- "this.interior.cbtext" may either be a<text> or an<inputtext>, therefore you cannot replace
"getText()" with "text" (does that mean we need to un-deprecate<text>#getText()?)
I deprecated getText() and updated test/lfc/legals/keyboardandmouse.lzx to
include an inputtext.ontext event - which updates for all runtimes.
LaszloView.lzs:
- description from setPlay() is now lost, b/c there isn't actually a "play" attribute
(just the "play" method)
Hrm, not sure what to do about this one. Perhaps deprecate play()?
- from setCursor() => "Or '' for default cursor." needs to be moved to cursor
declaration
Fixed.
- "setValign()" description sounds better to me than the current "valign"
description, other opinions here?
Fixed.
- no description for "align", needs to copied over from "setAlign()"
Fixed.
- set{Width, Height}() description also includes info about resource
stretching, copy to width/height?
Fixed.
- "layout" description does not include special case for removing layout, that
means {'class': 'none'}
Fixed.
LzText.lzs:
- "thickness" description does not include the limitation from
"setThickness()": [-200, 200]
Fixed.
- "sharpness" description does not include the limitation from
"setSharpness()": [-400, 400]
Fixed.
- "gridFit" description does not include the limitation from "setGridFit()": "none",
"pixel", or "subpixel"
Fixed.
- "antiAliasType" description does not include the limitation from "setAntiAliasType()":
"normal" or "advanced"
Fixed.
- for all attributes from above: attributes are set to @runtimes as2, whereas
method description says it's swf8+
Fixed. I also added a comment so the note about these being Flash-only shows
up in the docs.
LzInputText - Deprecate getText()
Tests: All tests run like before.
Files:
M WEB-INF/lps/lfc/views/LzInputText.lzs
M WEB-INF/lps/lfc/views/LzText.lzs
M WEB-INF/lps/lfc/views/LaszloView.lzs
M WEB-INF/lps/lfc/helpers/LzContextMenu.lzs
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/maxcarlson-20110108-NWq.tar
