Change maxcarlson-20110108-S6b by maxcarl...@friendly on 2011-01-08 14:27:43 PST
in /Users/maxcarlson/openlaszlo/trunk2
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: UPDATED: Make view shadow attribute application more efficient
Bugs Fixed: LPP-9632 - Make view shadow attribute application more efficient
Technical Reviewer: hminsky
QA Reviewer: ptw
Details: I'm going to check this in now. Updated to address Tucker's comments:
It seems to me there could be a race condition in this code.
Would it not be simpler for the shadow component setters to only call the
sprite if the view is inited, and also in init, if there are any shadow values,
call it?
Done!
Otherwise:
Update shadow state after this.inited to ensure all children are created. Be
smarter about if the shadow really needs to be updated or not.
Tests: components/demos/house.lzx?lzr=dhtml&lzt=html no longer shows 104 calls
to updateShadow(), about 16ms on my machine.
Files:
M WEB-INF/lps/lfc/views/LaszloView.lzs
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/maxcarlson-20110108-S6b.tar
