Yes, all changes for LPP-9736 are already checked in.

On 3/24/2011 8:28 PM, P T Withington wrote:
You're just going to check these in, right?  Seems to me that's the best QA we 
can afford right now.

On 2011-03-24, at 08:01, André Bargull wrote:

Change bargull-20110324-Cnh by bargull@Bargull02 on 2011-03-24 12:37:35
in /home/anba/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Update java sources for Java 5 (org.openlaszlo.sc.parser)

Bugs Fixed: LPP-9736 (Clean up java sources) (partial)

Technical Reviewer: (pending)
QA Reviewer: (pending)

Details:
Next round of updates, basically same changes as last time:
- Java5 enum used where applicable

- StringBuffer replaced with StringBuilder to avoid the synchronization overhead
-- but only for local variables, I didn't touch any public methods or class 
variables etc.

- Explicit allocation of wrapper classes (Integer, Long, Boolean, etc) is 
almost never necessary
-- replaced with valueOf() methods resp. auto-boxing


Tests:
compile lps.jar

Files:
M WEB-INF/lps/server/sc/src/org/openlaszlo/sc/parser/SimpleNode.java
M WEB-INF/lps/server/sc/src/org/openlaszlo/sc/parser/ASTLiteral.java
M WEB-INF/lps/server/sc/src/org/openlaszlo/sc/parser/ParseException.java
M WEB-INF/lps/server/sc/src/org/openlaszlo/sc/parser/ASTMethodDeclaration.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/bargull-20110324-Cnh.tar



Reply via email to