On Tue, Dec 8, 2009 at 1:39 AM, Bjorn Tillenius <[email protected]> wrote: > On Tue, Dec 08, 2009 at 02:46:13AM -0000, [email protected] wrote: >> Merge authors: >> Edwin Grubbs (edwin-grubbs) >> ------------------------------------------------------------ >> revno: 9987 [merge] >> committer: Launchpad Patch Queue Manager <[email protected]> >> branch nick: launchpad >> timestamp: Tue 2009-12-08 02:44:20 +0000 >> message: >> [r=noodles][ui=none][bug=230801] Fixed oops when renewing membership. >> modified: >> lib/lp/registry/browser/person.py >> >> >> -- >> lp:launchpad/devel >> https://code.launchpad.net/~launchpad-pqm/launchpad/devel >> >> You are subscribed to branch lp:launchpad/devel. >> To unsubscribe from this branch go to >> https://code.launchpad.net/~launchpad-pqm/launchpad/devel/+edit-subscription. > >> === modified file 'lib/lp/registry/browser/person.py' >> --- lib/lp/registry/browser/person.py 2009-11-21 14:45:26 +0000 >> +++ lib/lp/registry/browser/person.py 2009-12-03 02:50:03 +0000 >> @@ -548,7 +548,10 @@ >> �...@action(_("Renew"), name="renew") >> def renew_action(self, action, data): >> member = self.context.person >> - member.renewTeamMembership(self.context.team) >> + # This if-statement prevents an exception if the user >> + # double clicks on the submit button. >> + if self.context.canBeRenewedByMember(): >> + member.renewTeamMembership(self.context.team) >> self.request.response.addInfoNotification( >> _("Membership renewed until ${date}.", mapping=dict( >> date=self.context.dateexpires.strftime('%Y-%m-%d')))) > > Why isn't there a test for this change?
It seemed like a fairly small corner case to be testing. I can add a test for it. -Edwin _______________________________________________ Mailing list: https://launchpad.net/~launchpad-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-dev More help : https://help.launchpad.net/ListHelp
