-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10-12-13 09:45 AM, Brad Crittenden wrote: >> Thanks, but I'm looking for a guideline I can use as a reviewer to say >> "your tests are taking too long" or "your tests are astoundingly fast-- >> please share your secrets with the mailing list". Without numbers, I >> can't do that. > > Hi Aaron, > > Reviews are a discussion not simply enforcement of rules. I'd have no > problem saying "Wow, your new test provides great coverage but seems to be > really slow. Let's see if we can speed it up."
Certainly, reviews are not merely enforcement of rules. But I can't say "Wow, your new test provides great coverage but seems to be really slow. Let's see if we can speed it up." until I have a definition of "slow". Without numbers, I can't do that. Aaron -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk0GM2QACgkQ0F+nu1YWqI3H/wCeIEIhvDxXYbYDIK38vX4ombsT jekAn3wMxHkjwvDumTnWnxYiJQkAmdPS =5GRT -----END PGP SIGNATURE----- _______________________________________________ Mailing list: https://launchpad.net/~launchpad-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-dev More help : https://help.launchpad.net/ListHelp
