On Fri, Jan 7, 2011 at 9:16 AM, Robert Collins <[email protected]> wrote: > On Fri, Jan 7, 2011 at 9:05 AM, Aaron Bentley <[email protected]> wrote: >> * another anti-feature, IMO, since the messages usually don't need to be >> edited. > > So I changed that to support news_merge and bzr-builddeb both of which > generate messages which are often insufficient/incorrect; there needs > to be a way to support a user not wanting to continue (and hitting > ctrl-C cancels an entire process, not a good model for GUI's). > > We can change the contract further if needed to support lp-land, but I > haven't seen a bug describing how it doesn't work for lp-land.
Oh, and a small extra note: the behaviour in the prompt is *identical* to the previous behaviour when no commit message hooks were invoked - if the user exited with an unsable message the returned message was empty and higher level code looked for that - that is why the change I made returned an empty message, the calling code in bzr, bzr-gtk, bzr-explorer did not need to change. If lp-land wasn't handling empty messages as per the contract I can understand it getting confused, but it was already incorrect. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-dev More help : https://help.launchpad.net/ListHelp
