-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11-01-24 05:57 PM, Henning Eggers wrote: > Am 24.01.2011 08:26, schrieb Aaron Bentley: >> I think we should keep "Importing a module should not have side >> effects". One of the libraries used by launchpadlib for storing >> passwords does this, as does lp.codehosting, so we can't assume people >> will avoid it. > > We removed stuff that we felt is general software engineering knowledge that > everyone working here should know. Side effects are always bad, that is not > Launchpad-specific. Are we expecting too much possibly?
You have a point that this is general software engineering knowledge, not a matter of style. I even agree that Launchpad engineers "should" know better, but they don't always. I'm guilty of this, because I added the side effects in lp.codehosting. So sure, leave it out of the style guide. But we should probably say it *somewhere*. Aaron -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk0/fpUACgkQ0F+nu1YWqI33pACeOv1K/7sHw3vLu3L+qKBuRn/6 TNEAn0EBsmMOyPDakYqXNXeCDao1HYh/ =jz5q -----END PGP SIGNATURE----- _______________________________________________ Mailing list: https://launchpad.net/~launchpad-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-dev More help : https://help.launchpad.net/ListHelp
