-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 1/28/2011 4:32 PM, Max Kanat-Alexander wrote: > On 01/27/2011 02:46 PM, John Arbash Meinel wrote: >> I put together a branch which merges trunk into the pqm branch, and gets >> the test suite passing again. > > By the way, what's the coverage like on those tests? I was concerned > that they might not have great coverage. > > -Max
Well a few things: 1) Some of the tests were directly referencing 'bzrlib.plugins.historydb' because I forgot to redirect them. I'm still sorting that out. But it is probably why some of the tests were failing on trunk that could have been more mysterious. 2) Test coverage overall is pretty darn poor. Which is partially why loggerhead isn't particularly stable to hack on. (The things you are testing right now pass, but things you didn't think about start breaking.) I've tried to at least always leave things *better* than when I started it, but we're starting pretty low. It would certainly be good to at least have smoketests for regressions. I'm not 100% sure what a good test framework is for something like Loggerhead. I don't think we want to test too much at the WSGI level (integration vs unit tests, etc.). But we could certainly use a few integration-level tests. John =:-> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk1DSHkACgkQJdeBCYSNAAPw2ACguh86c2+CEaE7L7Nl0LO94aD5 VJkAnjXYFCfwsAdWkWl2cRZhgsSNVW/u =TMzX -----END PGP SIGNATURE----- _______________________________________________ Mailing list: https://launchpad.net/~launchpad-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-dev More help : https://help.launchpad.net/ListHelp
