On Mon, May 2, 2011 at 8:31 AM, Gary Poster <gary.pos...@canonical.com> wrote: > > On May 1, 2011, at 9:15 PM, Robert Collins wrote: > >> On Mon, May 2, 2011 at 12:55 PM, Gary Poster <gary.pos...@canonical.com> >> wrote: >>>> We need to decide what to do with these rows. Should they be removed? >>>> Should we set BugSubscriptionFilter.structuralsubscription to NULL? >>>> Are we removing the wrong StructuralSubscription rows? >>>> >>>> If they should be removed, it might be sane (and the simplest fix) to >>>> make the BugSubscriptionFilter.structuralsubscription foreign key ON >>>> DELETE CASCADE >>> >>> I believe that would be appropriate. If someone (Stuart? Yellow squad?) >>> could make this change, I would appreciate it. We had our baby Saturday, >>> so I will be out this week. >> >> I'm assuming you mean 'on delete cascade is appropriate'. > > Yes, thanks for clarifying that.
Unfortunately, I don't think we can take this simple approach as their is too much fallout. StructuralSubscription is referenced by BugSubscriptionFilter. BugSubscriptionFilter is referenced by BugNotificationFilter and 4 subtables. BugNotificationFilter is referenced by BugNotification BugNotification is referenced by Bug and Message Far too much fallout with all that cascading delete. I think we need to pull this patch until we can make the cleanup more intelligent. -- Stuart Bishop <stu...@stuartbishop.net> http://www.stuartbishop.net/ _______________________________________________ Mailing list: https://launchpad.net/~launchpad-dev Post to : launchpad-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-dev More help : https://help.launchpad.net/ListHelp
