On Thu, May 3, 2012 at 1:27 AM, Julian Edwards <julian.edwa...@canonical.com> wrote: > On Wednesday 02 May 2012 12:04:45 Jonathan Lange wrote: >> On Wed, May 2, 2012 at 11:36 AM, Julian Edwards >> >> <julian.edwa...@canonical.com> wrote: >> > On Tuesday 01 May 2012 15:05:30 Jonathan Lange wrote: >> >> On Mon, Apr 30, 2012 at 5:28 PM, Jonathan Lange <j...@mumak.net> wrote: >> >> ... >> >> >> >> > * add a boolean parameter to the subscription that controls whether >> >> > emails are sent >> >> >> >> This should have read "constructor" not "subscription". >> >> >> >> The corollary is that it would be stored as a field on Archive, and >> >> that anyone would be able to set it on construction. Presumably only >> >> PPA owners could change it. William jokingly suggested 'shut_up' as a >> >> name for this field. >> > >> > So basically s/commercial/shut_up/ >> >> Yeah. Probably spelled as "suppress_subscription_notifications" or >> something of that ilk. Would be simpler than 'commercial' in that it >> would need fewer special permissions and wouldn't be so easy to >> confuse with commercial_admin and things like that. >> >> jml > > I'd go for an enum instead of a bool, far more flexible. > > Call it "block_notifications" and we get a few possibilities: > > NONE > SUBSCRIPTIONS > ALL >
Cool. I'll work towards that then. jml _______________________________________________ Mailing list: https://launchpad.net/~launchpad-dev Post to : launchpad-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-dev More help : https://help.launchpad.net/ListHelp
