Review: Approve code
I am very pleased to see this enhancement. I expressed concerns that the 
@cachedproperty on is_valid_person and archive may cause issues during updated 
and subsequent displays of the person. eg, A user chooses to deactivate his 
profile, then the page loads and says he is still active, but reloading the 
page shows the page is deactivated. I am speculating though.

I think this is good to land. We will be prepared to address @cachedproperties 
as we do with Person.preferredemail, where the mutator function delete the 
_*_cached property to clear the state.
-- 
https://code.launchpad.net/~lifeless/launchpad/registry/+merge/32067
Your team Launchpad code reviewers is requested to review the proposed merge of 
lp:~lifeless/launchpad/registry into lp:launchpad/devel.

_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

Reply via email to