The proposal to merge lp:~jcsackett/launchpad/620494-downloads-sort into lp:launchpad/devel has been updated.
Description changed to: = Summary = Fixes an edge case sorting releases on +download by adding an additional sort field. Per the bug, if too releases have the same date, they can be sorted wrong from the fallback to database id. == Proposed fix == Add an additional sort by milestone.name; this catches the edge case and displays the releases correctly since most milestones use numeric names. == Pre-implementation notes == Talked with Curtis. == Implementation details == As in Proposed fix. == Tests == bin/test -vvc -t getMilestonesAndReleases == Demo and Q/A == On Thunderbird in dev (launchpad.dev/thunderbird) create two releases on trunk with milestones 0.99 and 0.98; make sure they have downloadable files. On http://launchpad.dev/thunderbird/+download you should see 0.99 listed before 0.98. = Launchpad lint = Checking for conflicts and issues in changed files. Linting changed files: lib/lp/registry/model/product.py lib/lp/registry/tests/test_product.py -- https://code.launchpad.net/~jcsackett/launchpad/620494-downloads-sort/+merge/33413 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/620494-downloads-sort into lp:launchpad/devel. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
