Review: Approve (13:32:29) Jeroen Vermeulen: stub: care to review a branch for me? It's a blocking risk, but not large. https://code.edge.launchpad.net/~jtv/launchpad/recife-pre-resetCurrentTranslation/+merge/33490 (13:35:22) stub: jtv: Not a blocking risk yet - nothing is using it apart from tests (13:35:52) Jeroen Vermeulen: stub: nothing I can _land_ now, no. Hence: blocking. (13:36:07) stub: You have an XXX that doesn't cite a bug. (13:36:32) stub: There are two ways of fixing that. (13:36:41) Jeroen Vermeulen: stub: our policy is currently not to file bugs too far in advance. It's listed in various places though. (13:37:23) stub: Our policy is also no XXX's without cited bugs IIRC. So remove three letters or create a bug I think are the options. (13:37:50) Jeroen Vermeulen: Okay, okay, I'm removing the XXX. (13:38:43) Jeroen Vermeulen: Pushing. (13:40:04) stub: jtv: IPOFile doesn't describe the parameters, which is minor but doesn't hurt to mention translator remains unchanged and timestamp is now by default. (13:40:06) Jeroen Vermeulen: Pushed. (13:40:56) stub: Otherwise all fine. -- https://code.launchpad.net/~jtv/launchpad/recife-pre-resetCurrentTranslation/+merge/33490 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/recife-pre-resetCurrentTranslation into lp:~launchpad/launchpad/recife.
_______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
