> Is homepage one word or two? Both forms are in common use and I don't know if > LP Style prefers homepage or home_page. Both "homepage" and "home page" are allowed according to my dictionary. "homepage" appears to be used more often in the Launchpad source code.
> DB patch is fine. It would be lovely if we could enforce the format of the > string using a CHECK constraint, but I don't think we can - we have to accept > whatever rubbish the user put in the package that they uploaded. You might > want to mention this in the comment before anyone attempts to naively mark it > up (possible attack vector there if someone sticks Javascript in the homepage > field and we don't validate the URL before marking it up). Makes sense, updated in the database comment and the API interface. -- https://code.launchpad.net/~jelmer/launchpad/621778-homepage-field/+merge/33331 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jelmer/launchpad/621778-homepage-field into lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
