Edwin Grubbs has proposed merging lp:~edwin-grubbs/launchpad/bug-635302-dsp-filebug-oops into lp:launchpad/devel.
Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: #635302 dsp implies I can report a bug on a distro without bug tracking enabled https://bugs.launchpad.net/bugs/635302 Summary ------- The bugs.lp.net/fedora/+source/$distributionsourcepackage page would display a list of bugs and the "Report a bug" button despite the fact that the distribution does not use Launchpad for tracking bugs. Implementation details ---------------------- Added conditionals for hiding the bug listing and the "Report a bug" button. It also sets robots=noindex,nofollow and displays a link to help.lp.net/Bugs like bugtarget-bugs.pt does. However, I did not add a link to configure the bugtracker, since buglisting-default.pt is used on so many different objects, and the code would have to determine if the object is part of a distribution or a project, which actually can have its bugtracker configured. lib/lp/bugs/templates/buglisting-default.pt lib/lp/bugs/browser/bugtask.py Adapt IDistributionSourcePackage/ISourcePackage to IServiceUsage and reduce the zcml for the IBreadcrumb adapter. lib/lp/registry/browser/distributionsourcepackage.py lib/lp/registry/browser/sourcepackage.py lib/lp/registry/configure.zcml Since buglisting-default.pt is also used by ProjectGroups, I made it implement the IServiceUsage interface. This meant that the browser.pillar.InvolvedMenu code could be simplified. lib/lp/registry/browser/pillar.py lib/lp/registry/interfaces/projectgroup.py lib/lp/registry/model/projectgroup.py Fix tests by setting bug_tracking_usage to LAUNCHPAD. I also corrected the indent of the python code in xx-distribution-statistics-portlet.txt. lib/lp/bugs/stories/bugtask-searches/xx-advanced-people-filters.txt lib/lp/bugs/stories/bugtask-searches/xx-advanced-upstream-pending-bugwatch.txt lib/lp/bugs/stories/bugtask-searches/xx-distribution-statistics-portlet.txt lib/lp/bugs/stories/bugtask-searches/xx-listing-basics.txt lib/lp/bugs/stories/bugtask-searches/xx-sort-orders.txt Tests ----- ./bin/test -vv -t 'xx-advanced-people-filters.txt|xx-advanced-upstream-pending-bugwatch.txt|xx-distribution-statistics-portlet.txt|xx-listing-basics.txt|xx-sort-orders.txt' Demo and Q/A ------------ * These pages should not show a list of bugs or the "Report a bug" button, but they should show the "Getting started with bug tracking in Launchpad" link. * Open http://launchpad.dev/debian/+source/mozilla-firefox * Open http://launchpad.dev/debian/sarge/+source/mozilla-firefox * Open http://launchpad.dev/apache * These pages should show the bug listing and the "Report a bug" button. * Open http://launchpad.dev/ubuntu/+source/mozilla-firefox * Open http://launchpad.dev/ubuntu/warty/+source/mozilla-firefox * Open http://launchpad.dev/gnome -- https://code.launchpad.net/~edwin-grubbs/launchpad/bug-635302-dsp-filebug-oops/+merge/37679 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~edwin-grubbs/launchpad/bug-635302-dsp-filebug-oops into lp:launchpad/devel. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
